Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner_common): add safety target object located on shoulder lane #6839

Merged
merged 1 commit into from
Apr 18, 2024

feat(behavior_path_planner_common): add target object located on shou…

d5a1cbc
Select commit
Loading
Failed to load commit list.
Merged

feat(behavior_path_planner_common): add safety target object located on shoulder lane #6839

feat(behavior_path_planner_common): add target object located on shou…
d5a1cbc
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Apr 17, 2024 in 38s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method objects_filtering.cpp: createTargetObjectsOnLane

Annotations

Check warning on line 388 in planning/behavior_path_planner_common/src/utils/path_safety_checker/objects_filtering.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

createTargetObjectsOnLane increases in cyclomatic complexity from 9 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File 

The lines of code increases from 1325 to 1334, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
View more details on CodeScene Delta Analysis