Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_obstacle_stop): set velocity factor to ROUTE_OBSTACLE #6669

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

set velocity factor of dynamic_obstacle_stop to ROUTE_OBSTACLE.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem requested a review from soblin as a code owner March 22, 2024 06:59
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 22, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (3a346c7) to head (58fe27b).
Report is 1 commits behind head on main.

Files Patch % Lines
...le_stop_module/src/scene_dynamic_obstacle_stop.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6669      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1925     1925              
  Lines      132736   132738       +2     
  Branches    39531    39531              
==========================================
  Hits        19625    19625              
- Misses      91139    91141       +2     
  Partials    21972    21972              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from 3a346c7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem enabled auto-merge (squash) March 22, 2024 08:07
@maxime-clem maxime-clem merged commit af04566 into autowarefoundation:main Mar 22, 2024
35 of 39 checks passed
@maxime-clem maxime-clem deleted the dyn_obs_stop/stop_factor branch March 22, 2024 08:21
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants