feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules #6625
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 15, 2024 in 38s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method turn_signal_decider.cpp: TurnSignalDecider::getBehaviorTurnSignalInfo
Annotations
Check warning on line 755 in planning/behavior_path_planner_common/src/turn_signal_decider.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
TurnSignalDecider::getBehaviorTurnSignalInfo has a cyclomatic complexity of 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/behavior_path_planner_common/src/turn_signal_decider.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 7.25 to 8.46, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading