-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules #6625
feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules #6625
Conversation
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6625 +/- ##
==========================================
+ Coverage 14.79% 14.83% +0.04%
==========================================
Files 1920 1920
Lines 132398 134201 +1803
Branches 39345 40636 +1291
==========================================
+ Hits 19582 19904 +322
- Misses 90970 92193 +1223
- Partials 21846 22104 +258
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
52b2fd6
into
autowarefoundation:main
…g turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…g turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…g turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…g turn signal for bpp modules v0.19.1 (#1313) * feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(behavior_path_avoidance_module): use the general calc turn signal method (autowarefoundation#6626) use the general calc turn signal method Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(lane_change_module): add general method to get turn signal for LC module (autowarefoundation#6627) add general method to get turn signal for LC module Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(start_planner): add general turn signal method to start planner (autowarefoundation#6628) * Add general turnSignal method to start planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add description to ignore signal Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(goal_planner): add general turnsignalinfo method for goal planner (autowarefoundation#6629) add general turnsignalinfo method for goal planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflict * add turn_signal_remaining_shift_length_threshold Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * include utility header to use std::pair --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…g turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Description
Add a general method to obtain the correct turnSignalInfo for all behavior path planner modules.
This PR implements only the method itself. The method has been tested with the start planner, goal planner, avoidance and lane change modules as depicted here: #6622
This PR is 1 of 5 and the other PRs will depend on this one (to be linked)
Please see the Above link for further details
After approving this PR, the following PRs implement this method in the bpp modules:
Avoidance: #6626
Lane Change: #6627
Start Planner: #6628
Goal Planner: #6629
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.