fix(behavior_path_planner): catch exception when calculating curvature #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
requested review from
danielsanchezaran,
rej55,
kosuke55,
soblin,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
shmpwk
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6431 +/- ##
=======================================
Coverage 14.99% 14.99%
=======================================
Files 1839 1839
Lines 127158 127163 +5
Branches 38099 38103 +4
=======================================
+ Hits 19070 19071 +1
- Misses 86755 86759 +4
Partials 21333 21333
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
deleted the
fix/drivable_area_expansion-catch-curvature-exception
branch
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
autowarefoundation#6431) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
#6431) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
autowarefoundation#6431) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
autowarefoundation#6431) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
behavior_path_plannermay crash if some points in the map are too close to eachother or form a too sharp angle.This PR prevents crashes by handling the exception that may occur when calculating curvatures of the path.
Tests performed
Psim
Effects on system behavior
No crash on bad maps
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.