feat(compare_map_segmentation): change height downsize logic #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
requested review from
amc-nu,
badai-nguyen and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
badai-nguyen
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6429 +/- ##
==========================================
- Coverage 14.99% 14.97% -0.03%
==========================================
Files 1838 1843 +5
Lines 127099 127312 +213
Branches 38075 38065 -10
==========================================
Hits 19062 19062
- Misses 86715 86928 +213
Partials 21322 21322
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…efoundation#6429) * fix: change height downsize logic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * changed inclusion model from sphere to cube Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Merged
7 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…efoundation#6429) * fix: change height downsize logic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * changed inclusion model from sphere to cube Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focused function has intention to reduce height distance effect so that the function won't filter out ground pointcloud.
Problem in original code is that it will also reduce the horizontal error threshold since 3d euclidean distance is just reduced.
I changed inclusion decision logic from 3d euclidean distance to comparison with each axis: which will more easier to understand and tune.
Tests performed
Tested with X2 rosbag.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.