-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(learned_model): create package #6395
feat(learned_model): create package #6395
Conversation
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6395/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please finish addressing all the comments and add copyrights to all the new files.
You should also make sure all the required checks are passing. For example https://results.pre-commit.ci/run/github/429651616/1709574266.1edMl4owQtGa-5vXW0GnQg
...anning_simulator/src/simple_planning_simulator/vehicle_model/sim_model_learned_steer_vel.cpp
Outdated
Show resolved
Hide resolved
simulator/learned_model/include/learned_model/submodel_interface.hpp
Outdated
Show resolved
Hide resolved
...ng_simulator/include/simple_planning_simulator/vehicle_model/sim_model_learned_steer_vel.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6395 +/- ##
==========================================
- Coverage 14.93% 14.79% -0.15%
==========================================
Files 1944 1929 -15
Lines 134033 132392 -1641
Branches 39871 39467 -404
==========================================
- Hits 20023 19583 -440
+ Misses 91718 90908 -810
+ Partials 22292 21901 -391
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Tomas Nagy <tomas@pmc.sk>
Description
This PR creates a new package that enables running trained python vehicle models in the
simple_planning_simulator
. The main purpose of this PR is to have an easy way of launching python trained ML models in the simulator without a need for an extensive C++ code.Related links
PyBind11
COMPANY INTERNAL LINK - How to properly launch this PR to test it
Tests performed
I tested this feature by using different python models, using different launch parameters while simulating the motion of the vehicle in the simulator.
Notes for reviewers
I created a tutorial on how to launch some basic trained python models. (see links)
There can be an issue with dependencies that I haven't been able to resolve yet. This feature depends on the
python3
andpybind11
which probably cannot be installed using rosdep.Interface changes
This PR changes the interface of
simple_planning_simulator
slightly by adding a few more launch parameters (more on this in the updated documentation). However, this PR does not remove any functionality ofsimple_planning_simulator
and does not break the interface.Effects on system behavior
This PR adds a new model to
simple_planning_simulator
. This PR does not break the existing code ofsimple_planning_simulator
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.