fix(start_planner): remove front of shift start pose from collision check section #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
danielsanchezaran,
kosuke55,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
shmpwk
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6374 +/- ##
==========================================
- Coverage 14.88% 14.88% -0.01%
==========================================
Files 1838 1838
Lines 126699 126709 +10
Branches 38042 38042
==========================================
Hits 18865 18865
- Misses 86535 86545 +10
Partials 21299 21299
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
removed
the
run:build-and-test-differential
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kosuke55
approved these changes
Feb 11, 2024
Comment on lines
-740
to
-743
| // remove the point behind of collision check end pose | ||
| combined_path.points.erase( | ||
| combined_path.points.begin() + collision_check_end_idx + 1, combined_path.points.end()); | ||
| return combined_path; |
There was a problem hiding this comment.
memo:
this kept points before all points before collision_check_end_idx including points before start pose
kosuke55
added
the
run:build-and-test-differential
…alization (autowarefoundation#6376) * separate debug and info marker Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace util function for footprint Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:launch
kyoichi-sugahara
force-pushed
the
fix/remove_front_points
branch
from
bfa18fa to
d29cb27
Compare
github-actions
bot
removed
the
component:launch
|
confirmed no degression with start_planner related scenario. |
kyoichi-sugahara
merged commit a10f9c4
into
autowarefoundation:main
23 of 25 checks passed
shmpwk
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Feb 12, 2024
…heck section (autowarefoundation#6374) * remove front of shift start pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor collision check section extraction in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…heck section (autowarefoundation#6374) * remove front of shift start pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor collision check section extraction in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…heck section (autowarefoundation#6374) * remove front of shift start pose Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor collision check section extraction in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
points front of shift start pose was used for collision check
That was causing the problem of not generating shift pull out path when object is located at behind of ego vehicle
Now shift pull out path can be generated even when object is located at behind of ego vehicle
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.