Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mpc_lateral_controller): visualize/correct the longitudinal and lateral deviations for pid and mpc #6268

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

c7cef56
Select commit
Loading
Failed to load commit list.
Draft

feat(mpc_lateral_controller): visualize/correct the longitudinal and lateral deviations for pid and mpc #6268

style(pre-commit): autofix
c7cef56
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 1, 2024 in 53s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

Annotations

Check notice on line 1 in control/mpc_lateral_controller/src/mpc.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 4.79 to 4.84, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.