feat(default_ad_api): add door api #5737
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Mar 13, 2024 in 48s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method door_panel.cpp: DoorPanel::onInitialize
- Bumpy Road Ahead dummy_doors.cpp: DummyDoors::on_command
- Bumpy Road Ahead dummy_doors.cpp: DummyDoors::on_timer
Annotations
Check warning on line 104 in common/tier4_adapi_rviz_plugin/src/door_panel.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
DoorPanel::onInitialize has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 66 in simulator/vehicle_door_simulator/src/dummy_doors.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
DummyDoors::on_command has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 112 in simulator/vehicle_door_simulator/src/dummy_doors.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
DummyDoors::on_timer has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading