Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): add door api #5737

Merged
merged 13 commits into from
Mar 27, 2024

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 1, 2023

Description

Add default implementation for door API and door simulation tools.

  • Door API (default_ad_api)
  • Door simulator (vehicle_device_simulator)
  • Door panel (tier4_adapi_rviz_plugin)

Related links

autowarefoundation/autoware_launch#921
https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/features/vehicle-doors/

Tests performed

  1. Checkout feat: add dummy doors for planning simulator autoware_launch#921 and build.
  2. Launch planning simulator.
  3. Add door panel on rviz (tier4_adapi_rviz_plugin -> DoorPanel)
  4. Press open/close button and check status.

Screenshot from 2023-12-01 13-50-09

Notes for reviewers

None

Interface changes

Add

  • /api/vehicles/doors/command
  • /api/vehicles/doors/layout
  • /api/vehicles/doors/status
  • /vehicles/doors/command
  • /vehicles/doors/layout
  • /vehicles/doors/status

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi marked this pull request as ready for review December 1, 2023 04:52
@isamu-takagi isamu-takagi self-assigned this Dec 1, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Dec 1, 2023
@isamu-takagi isamu-takagi changed the title Feat/adapi door feat(default_ad_api): add door api Dec 1, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link

stale bot commented Jan 30, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 30, 2024
Copy link
Contributor

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Mar 6, 2024
@mitsudome-r mitsudome-r self-requested a review March 7, 2024 07:04
isamu-takagi and others added 2 commits March 13, 2024 15:29
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Mar 13, 2024
@isamu-takagi isamu-takagi enabled auto-merge (squash) March 26, 2024 10:19
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 2.23881% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 14.87%. Comparing base (fcebec6) to head (30502ae).
Report is 56 commits behind head on main.

Files Patch % Lines
common/tier4_adapi_rviz_plugin/src/door_panel.cpp 0.00% 64 Missing ⚠️
...mulator/vehicle_door_simulator/src/dummy_doors.cpp 0.00% 61 Missing ⚠️
system/default_ad_api/src/vehicle_door.cpp 33.33% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5737      +/-   ##
==========================================
+ Coverage   14.79%   14.87%   +0.08%     
==========================================
  Files        1920     1923       +3     
  Lines      132349   138085    +5736     
  Branches    39339    42697    +3358     
==========================================
+ Hits        19578    20545     +967     
- Misses      90935    94991    +4056     
- Partials    21836    22549     +713     
Flag Coverage Δ *Carryforward flag
differential 14.72% <2.23%> (?)
total 14.79% <ø> (ø) Carriedforward from fcebec6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit d26565d into autowarefoundation:main Mar 27, 2024
34 of 36 checks passed
@isamu-takagi isamu-takagi deleted the feat/adapi-door branch March 27, 2024 02:40
badai-nguyen pushed a commit to tier4/autoware_universe that referenced this pull request Apr 23, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
badai-nguyen pushed a commit to tier4/autoware_universe that referenced this pull request Apr 23, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
badai-nguyen pushed a commit to tier4/autoware_universe that referenced this pull request May 9, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants