Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): refactor lane change turn signal info #3985

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jun 15, 2023

Description

Clean code and remove unused codes in the lane change turn signal related functions.

Tests performed

PSim.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ange turn signal deactivation

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 15, 2023

// desired end pose
const auto & length_ratio =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const auto & length_ratio =
const auto length_ratio =

this returns trivial type, so you dont need &

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with previous PR

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (90683e5) 14.40% compared to head (bf466c4) 14.40%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3985    +/-   ##
========================================
  Coverage   14.40%   14.40%            
========================================
  Files        1456     1456            
  Lines      102760   102751     -9     
  Branches    29783    30189   +406     
========================================
  Hits        14801    14801            
+ Misses      71783    71771    -12     
- Partials    16176    16179     +3     
Flag Coverage Δ *Carryforward flag
differential 12.77% <0.00%> (?)
total 14.41% <ø> (+0.01%) ⬆️ Carriedforward from 290bb71

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 9.75% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 100.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.30% <0.00%> (-0.05%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 3.68% <0.00%> (+0.03%) ⬆️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.88% <ø> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 merged commit bcc93c1 into main Jun 15, 2023
@purewater0901 purewater0901 deleted the refactor/lc-turn-signal-function branch June 15, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants