-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): refactor lane change turn signal info #3985
Conversation
…ange turn signal deactivation Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
|
||
// desired end pose | ||
const auto & length_ratio = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const auto & length_ratio = | |
const auto length_ratio = |
this returns trivial type, so you dont need &
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with previous PR
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
========================================
Coverage 14.40% 14.40%
========================================
Files 1456 1456
Lines 102760 102751 -9
Branches 29783 30189 +406
========================================
Hits 14801 14801
+ Misses 71783 71771 -12
- Partials 16176 16179 +3
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: yutaka <purewater0901@gmail.com>
Description
Clean code and remove unused codes in the lane change turn signal related functions.
Tests performed
PSim.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.