Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tenssort_common): validate TensorRT engine version for cached engine #10320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amadeuszsz
Copy link
Contributor

Description

Rebuilds engine if cached engine file was build with different version of TensorRT.
TensorRT does not expose API for checking engine before deserialization (at least I couldn't find).
Source of implementation: NVIDIA/TensorRT#3073 (comment)

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…d engine

Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@amadeuszsz amadeuszsz self-assigned this Mar 21, 2025
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 21, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@amadeuszsz amadeuszsz added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 21, 2025
@amadeuszsz amadeuszsz changed the title autoware_tenssort_common): validate TensorRT engine version for cached engine feat(autoware_tenssort_common): validate TensorRT engine version for cached engine Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 25.92%. Comparing base (69c0a32) to head (f67a830).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/autoware_tensorrt_common/src/tensorrt_common.cpp 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10320      +/-   ##
==========================================
- Coverage   25.93%   25.92%   -0.01%     
==========================================
  Files        1383     1383              
  Lines      106829   106854      +25     
  Branches    40907    40914       +7     
==========================================
  Hits        27705    27705              
- Misses      76416    76441      +25     
  Partials     2708     2708              
Flag Coverage Δ *Carryforward flag
differential 8.37% <ø> (?)
differential-cuda 6.48% <0.00%> (?)
total 25.93% <ø> (+<0.01%) ⬆️ Carriedforward from 69c0a32

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant