Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(control): remove unimplemented function declarations #10314

Conversation

Autumn60
Copy link
Contributor

Description

For LaneDepartureCheckerNode class,
In #7358 , the implementation of the callback function has been removed, but the declaration has not.

Related links

#7358

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Mar 20, 2025
Copy link

github-actions bot commented Mar 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Autumn60 Autumn60 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 20, 2025
@Autumn60 Autumn60 requested a review from takayuki5168 March 20, 2025 05:03
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.34%. Comparing base (63c5607) to head (0fbf54e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10314      +/-   ##
==========================================
+ Coverage   25.94%   26.34%   +0.39%     
==========================================
  Files        1383     1387       +4     
  Lines      106833   107415     +582     
  Branches    40912    41006      +94     
==========================================
+ Hits        27722    28297     +575     
+ Misses      76403    76401       -2     
- Partials     2708     2717       +9     
Flag Coverage Δ *Carryforward flag
differential 26.48% <ø> (?)
total 25.92% <ø> (-0.03%) ⬇️ Carriedforward from dc44b22

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@Autumn60 Autumn60 enabled auto-merge (squash) March 21, 2025 04:15
@Autumn60 Autumn60 merged commit 69c0a32 into autowarefoundation:main Mar 21, 2025
33 of 35 checks passed
@Autumn60 Autumn60 deleted the refactor/control/remove_unnecessary_func branch March 21, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants