feat(probabilistic_occupancy_grid_map): add diagnostics warning when latency is too long #10280
+25
−0
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 17, 2025 in 32s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Bumpy Road Ahead)
(1 file with Complex Method, Large Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| pointcloud_based_occupancy_grid_map_node.cpp | 1 critical rule | 8.95 → 8.46 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| pointcloud_based_occupancy_grid_map_node.cpp | 2 advisory rules | 8.95 → 8.46 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Bumpy Road Ahead pointcloud_based_occupancy_grid_map_node.cpp: PointcloudBasedOccupancyGridMapNode::onPointcloudWithObstacleAndRaw
- Complex Method pointcloud_based_occupancy_grid_map_node.cpp: PointcloudBasedOccupancyGridMapNode::onPointcloudWithObstacleAndRaw
- Large Method pointcloud_based_occupancy_grid_map_node.cpp: PointcloudBasedOccupancyGridMapNode::PointcloudBasedOccupancyGridMapNode
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PointcloudBasedOccupancyGridMapNode::onPointcloudWithObstacleAndRaw increases in cyclomatic complexity from 16 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
PointcloudBasedOccupancyGridMapNode::PointcloudBasedOccupancyGridMapNode increases from 83 to 86 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Bumpy Road Ahead
PointcloudBasedOccupancyGridMapNode::onPointcloudWithObstacleAndRaw increases from 4 to 5 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading