Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probabilistic_occupancy_grid_map): add diagnostics warning when latency is too long #10280

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ogrex
Copy link

@ogrex ogrex commented Mar 17, 2025

Description

Related links

Parent Issue:

  • Link

How was this PR tested?

Tested by running logging simulator

OK:
image

Warnings:
image

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ogrex ogrex requested a review from technolojin March 17, 2025 07:27
@technolojin technolojin self-assigned this Mar 17, 2025
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to https://github.com/autowarefoundation/autoware.universe/pull/10257/files#, it would be better to set tolerance duration of is_delay_within_range=false

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss comment

@ogrex ogrex marked this pull request as ready for review March 19, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants