Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_velocity_planner_common): replace autoware_universe_utils with autoware_utils #10154

Conversation

mitsudome-r
Copy link
Member

Description

This PR replace autoware_universe_utils with autoware_utils in autoware_route_handler as a preparation for porting to Autoware Core.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 18, 2025
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55
Copy link
Contributor

kosuke55 commented Feb 19, 2025

@soblin @rej55 @shmpwk
could you review this PR? we want to merge today

@mitsudome-r mitsudome-r marked this pull request as draft February 19, 2025 03:24
@mitsudome-r mitsudome-r force-pushed the replace-autoware-utils-behavor-velocity-planner-common branch 2 times, most recently from 3ccba1c to 7a25e5c Compare February 19, 2025 19:26
@mitsudome-r
Copy link
Member Author

This should be merged after #10167

mitsudome-r and others added 7 commits February 25, 2025 13:49
…verse_utils with autoware_utils

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
…h autoware_utils in

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@xmfcx xmfcx force-pushed the replace-autoware-utils-behavor-velocity-planner-common branch from 631f8f2 to 5f398fc Compare February 25, 2025 04:49
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 54.28571% with 32 lines in your changes missing coverage. Please review.

Project coverage is 26.76%. Comparing base (a11a3ee) to head (5f398fc).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
planning/autoware_velocity_smoother/src/node.cpp 21.05% 15 Missing ⚠️
...utoware_velocity_smoother/src/trajectory_utils.cpp 55.55% 4 Missing ⚠️
...r_velocity_planner_common/src/utilization/util.cpp 62.50% 2 Missing and 1 partial ⚠️
...anning/autoware_velocity_smoother/src/resample.cpp 0.00% 0 Missing and 2 partials ⚠️
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% 2 Missing ⚠️
...e_velocity_smoother/src/smoother/smoother_base.cpp 60.00% 1 Missing and 1 partial ⚠️
..._smoother/analytical_jerk_constrained_smoother.cpp 66.66% 0 Missing and 1 partial ⚠️
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 88.88% 1 Missing ⚠️
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% 1 Missing ⚠️
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10154      +/-   ##
==========================================
- Coverage   26.79%   26.76%   -0.03%     
==========================================
  Files        1395     1397       +2     
  Lines      107936   108145     +209     
  Branches    41545    41568      +23     
==========================================
+ Hits        28918    28947      +29     
- Misses      76141    76319     +178     
- Partials     2877     2879       +2     
Flag Coverage Δ *Carryforward flag
differential 22.41% <54.28%> (?)
total 26.77% <ø> (-0.02%) ⬇️ Carriedforward from a11a3ee

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 28, 2025

Someone modified the files :(

@mitsudome-r could you rebase this PR?

@mitsudome-r
Copy link
Member Author

This was included in #10191 so closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants