-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_behavior_velocity_planner_common from autoware.universe to autoware.core #230
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
ERROR: the following packages/stacks could not have their rosdep keys resolved ci would pass after autoware_velocity_smoother ported. |
|
Signed-off-by: suchang <chang.su@autocore.ai>
…ithub.com/autowarefoundation/autoware.core into autoware_behavior_velocity_planner_common
26e146d
to
c9bf077
Compare
|
29b20f6
to
335409b
Compare
📄 Phase 1 Target Packages Google Sheets Link This package depends on:
|
Hello Fatih san @xmfcx I found that the package stop-line-module we are porting in this pr only use test_utils function from autoware_behavior_velocity_planner to generate a virture autoware_behavior_velocity_planner node for test case in file https://github.com/autowarefoundation/autoware.universe/blob/0f1bfb6e65a874a1ec30f62c473b4ec516aa5471/planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module/test/test_node_interface.cpp#L56. Autoware_behavior_velocity_planner involves too much packages( some are not planned to be ported to core repo), maybe that's the reason it is not on the porting list. My idea is we remove this test case, and write new test case in the future according to its usage in core repo What do you think of this solution ? @xmfcx Best regards 心刚 |
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
335409b
to
9b1424b
Compare
hi fatih san What do you think of the solution #230 (comment) ? Best regards 心刚 |
Got confirmation from mits san will port behavior_velocity_planner too i will add it to the porting list 心刚 |
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Description
feat: port autoware_behavior_velocity_planner_common from autoware.universe to autoware.core
Related links
Parent Issue:
Must be merged after:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.