Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port autoware_behavior_velocity_planner_common from autoware.universe to autoware.core #230

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

storrrrrrrrm
Copy link

@storrrrrrrrm storrrrrrrrm commented Feb 28, 2025

Description

feat: port autoware_behavior_velocity_planner_common from autoware.universe to autoware.core

Related links

Parent Issue:

Must be merged after:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

suchang added 2 commits February 27, 2025 18:00
Signed-off-by: suchang <chang.su@autocore.ai>
Signed-off-by: suchang <chang.su@autocore.ai>
Copy link

github-actions bot commented Feb 28, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@storrrrrrrrm storrrrrrrrm added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 28, 2025
@storrrrrrrrm storrrrrrrrm changed the title feat: port behavior_velocity_planner_common from autoware.universe to autoware.core feat: port autoware_behavior_velocity_planner_common from autoware.universe to autoware.core Feb 28, 2025
@xmfcx xmfcx added the type:moving Temporary label to represent packages that are specifically moving from Universe to Core. label Feb 28, 2025
@storrrrrrrrm
Copy link
Author

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
autoware_behavior_velocity_planner_common: Cannot locate rosdep definition for [autoware_velocity_smoother]

ci would pass after autoware_velocity_smoother ported.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 28, 2025

@xmfcx xmfcx marked this pull request as draft February 28, 2025 07:46
@liuXinGangChina liuXinGangChina force-pushed the autoware_behavior_velocity_planner_common branch from 26e146d to c9bf077 Compare March 7, 2025 05:13
@xmfcx
Copy link
Contributor

xmfcx commented Mar 13, 2025

@xmfcx xmfcx force-pushed the autoware_behavior_velocity_planner_common branch from 29b20f6 to 335409b Compare March 13, 2025 13:16
@xmfcx
Copy link
Contributor

xmfcx commented Mar 13, 2025

https://github.com/autowarefoundation/autoware.core/actions/runs/13835559832/job/38709590361?pr=230#step:5:296

📄 Phase 1 Target Packages Google Sheets Link

This package depends on:

  • autoware_behavior_velocity_planner (not in the gsheet)
  • autoware_velocity_smoother

@liuXinGangChina
Copy link
Contributor

https://github.com/autowarefoundation/autoware.core/actions/runs/13835559832/job/38709590361?pr=230#step:5:296

📄 Phase 1 Target Packages Google Sheets Link

This package depends on:

* autoware_behavior_velocity_planner (not in the gsheet)

* autoware_velocity_smoother

Hello Fatih san @xmfcx

I found that the package stop-line-module we are porting in this pr only use test_utils function from autoware_behavior_velocity_planner to generate a virture autoware_behavior_velocity_planner node for test case in file https://github.com/autowarefoundation/autoware.universe/blob/0f1bfb6e65a874a1ec30f62c473b4ec516aa5471/planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module/test/test_node_interface.cpp#L56.

Autoware_behavior_velocity_planner involves too much packages( some are not planned to be ported to core repo), maybe that's the reason it is not on the porting list.

My idea is we remove this test case, and write new test case in the future according to its usage in core repo

What do you think of this solution ? @xmfcx

Best regards

心刚

suchang and others added 5 commits March 15, 2025 16:47
@liuXinGangChina liuXinGangChina force-pushed the autoware_behavior_velocity_planner_common branch from 335409b to 9b1424b Compare March 15, 2025 08:47
@liuXinGangChina
Copy link
Contributor

hi fatih san

What do you think of the solution #230 (comment)

Best regards

心刚

@liuXinGangChina
Copy link
Contributor

Got confirmation from mits san

will port behavior_velocity_planner too

i will add it to the porting list

心刚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core.
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

3 participants