Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update autoware's image tag #7952

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 10, 2024

Description

This PR updates the tag names of the docker images used in the GitHub Actions workflow, based on corrections from the PR autowarefoundation/autoware#4961.

Related links

https://github.com/orgs/autowarefoundation/discussions/4661#discussioncomment-9995806

How was this PR tested?

https://github.com/autowarefoundation/autoware.universe/actions/runs/10054982444?pr=7952

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

youtalk added 2 commits July 23, 2024 16:17
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk force-pushed the update-docker-tag branch from 7063a37 to a69e75c Compare July 23, 2024 07:22
youtalk added 2 commits July 23, 2024 16:23
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk changed the title change autoware's docker tag feat(ci): update autoware's image tag Jul 23, 2024
@youtalk youtalk self-assigned this Jul 23, 2024
@youtalk youtalk marked this pull request as ready for review July 23, 2024 07:27
@youtalk youtalk requested review from xmfcx and mitsudome-r July 23, 2024 07:27
@youtalk
Copy link
Member Author

youtalk commented Jul 23, 2024

autowarefoundation/autoware#4961 (comment)

It seems like some of the workflows in Autoware.Universe uses prebuilt image. If we are removing them, we should update Autoware.Universe CIs to use devel environment instead.

container: ghcr.io/autowarefoundation/autoware:latest-prebuilt

@mitsudome-r This PR resolves the problem.

@youtalk youtalk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2024
@youtalk youtalk marked this pull request as draft July 23, 2024 07:37
@youtalk
Copy link
Member Author

youtalk commented Jul 23, 2024

build-and-test-differential / build-and-test-differential (humble, -cuda) was failed. I need to fix it.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
Copy link
Member Author

youtalk commented Jul 23, 2024

build-and-test-differential was succeeded by using the multi-arch image c81e994.
It's ready for review.

@youtalk youtalk marked this pull request as ready for review July 23, 2024 08:07
@mitsudome-r mitsudome-r merged commit 1f7122a into autowarefoundation:main Jul 23, 2024
25 of 26 checks passed
@youtalk youtalk deleted the update-docker-tag branch July 23, 2024 08:19
@xmfcx
Copy link
Contributor

xmfcx commented Jul 23, 2024

Before

image

After (This PR)

image

Disk space usage change

New image uses 0.8GB more disk space.

Also,

chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
* change autoware's docker tag

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update tags

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* typo

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* use multiarch image

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
* change autoware's docker tag

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update tags

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* typo

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* use multiarch image

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants