-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker,ci): split prebuilt stage into autoware-core and autoware-universe stages #4961
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
It seems like some of the workflows in Autoware.Universe uses prebuilt image. If we are removing them, we should update Autoware.Universe CIs to use devel environment instead. |
@mitsudome-r That's good catch! Since |
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
I made a PR to resolve the |
I'm sorry but I sent the message to the different PR.
|
@youtalk thanks for the updates. Could you add the following directly into the autoware/docker/README.md file: ## Images
Images diagram (in mermaid format please)
### base
- imports from X
- used for X
- contains X
### rosdep-depend
... So we can understand what's happening easily. |
@xmfcx It seems there is no de facto standard syntax for writing multi-stage build |
@xmfcx Is it okay to separate the |
@youtalk I see, I didn't know it was generated by dockerfilegraph, which uses graphviz, same as what colcon uses to visualize the package dependency graph! https://github.com/patrickhoefler/dockerfilegraph?tab=readme-ov-file#more-options Here it has
That's alright, as long as we have the documentation in sync with the dockerfile. |
By the way, I need something like this: |
@xmfcx I will make a PR to write the README. Thank you for you understanding. |
Description
This PR is the first step in this discussion https://github.com/orgs/autowarefoundation/discussions/4661#discussioncomment-9995806.
The
Dockerfile
'sprebuilt
stage will be divided into two stages:autoware-core
andautoware-universe
.Additionally, the
src-imported
stage, which was prepared forvcs import
, has now been renamed torosdep-depend
becausesrc
is no longer imported viavcs import
but simply calledCOPY
.The current
Dockerfile
This PR's
Dockerfile
Tests performed
https://github.com/youtalk/autoware/actions/runs/9868168693
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.