Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): ignore objects coming from behind ego #7891

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jul 8, 2024

Description

Add an option to ignore objects coming from behind the ego vehicle in the out_of_lane module.

Related links

How was this PR tested?

ROSBag
Psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-ignore-objects-behind branch from 13a5bca to 6b7f581 Compare July 8, 2024 07:46
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem marked this pull request as ready for review July 9, 2024 07:43
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.42%. Comparing base (598d937) to head (85fa306).
Report is 12 commits behind head on main.

Files Patch % Lines
...ut_of_lane_module/src/filter_predicted_objects.cpp 0.00% 5 Missing ⚠️
...city_out_of_lane_module/src/out_of_lane_module.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7891      +/-   ##
==========================================
- Coverage   28.42%   28.42%   -0.01%     
==========================================
  Files        1588     1592       +4     
  Lines      116185   116224      +39     
  Branches    49559    49564       +5     
==========================================
+ Hits        33031    33037       +6     
- Misses      74186    74219      +33     
  Partials     8968     8968              
Flag Coverage Δ *Carryforward flag
differential 9.03% <25.00%> (?)
total 28.42% <ø> (+<0.01%) ⬆️ Carriedforward from 598d937

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit ab841bc into autowarefoundation:main Jul 22, 2024
39 of 41 checks passed
@maxime-clem maxime-clem deleted the feat/out_of_lane-ignore-objects-behind branch July 22, 2024 08:53
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
…ndation#7891)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 23, 2024
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jul 23, 2024
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Jul 31, 2024
…ndation#7891)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 1, 2024
…ndation#7891) (#1437)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants