feat(autoware_behavior_path_planner): prevent infinite loop in approving scene module process

[kyoichi-sugahara]

Description

This PR should be merged first.

Current potential issue:

When scene modules A > B > C are in the approved state and A fails, all modules (A, B, C) are removed from approved_modules. Additionally, candidate_modules becomes empty, causing all modules A-Z to be re-evaluated through getRequestModules -> runRequestModules. This leads to A > B > C being approved again, and if A fails once more, an infinite loop may occur.

Proposed solution:

Prevent modules that have been removed from approved_modules due to success or failure from being added again by getRequestModules.

1. In runApprovedModules, add modules that have transitioned to success or failure state to deleted_modules.
2. In getRequestModules, skip the execution request judgment for modules that have been added to deleted_modules.

Additional change:

By implementing a process to delete modules that have either succeeded or failed in the loop, the maximum number of loops can now be theoretically determined based on the number of scene modules. As a result, I've changed the method to calculate the theoretical maximum instead of using a parameter definition.

How was this PR tested?

• run psim
• PASS TIERIV INTERNAL SCENARIOS
• PASS TIERIV INTERNAL SCENARIOS with removing max_iteration_num parameter

Notes for reviewers

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.43%. Comparing base (6d0247e) to head (10320d1).
Report is 3 commits behind head on main.

Files	Patch %	Lines
...ware_behavior_path_planner/src/planner_manager.cpp	75.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7881      +/-   ##
==========================================
- Coverage   28.44%   28.43%   -0.01%     
==========================================
  Files        1591     1597       +6     
  Lines      116213   116265      +52     
  Branches    49613    49617       +4     
==========================================
+ Hits        33059    33063       +4     
- Misses      74141    74188      +47     
- Partials     9013     9014       +1     

Flag	Coverage Δ		*Carryforward flag
differential	12.52% <80.00%> (?)
total	28.44% <ø> (-0.01%)	⬇️	Carriedforward from 6d0247e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.