-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_tracking_object_merger): move headers to include/autoware and rename package #7809
refactor(autoware_tracking_object_merger): move headers to include/autoware and rename package #7809
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
package renaming
I am thinking to do it after all the other packages are ready. -
moving headers
the association class will be replaced by shared library. mentioned in refactor(autoware_object_merger): move headers to src and rename package #7804 (review)
Do you have an estimate for when this will be done? Why not do it now for each package? We've done it for other subsystems (planning, localization, common, etc.)
It's best to do it now and then if you want to create a third package that provides a shared library, then you can do it, but there's no estimate when the shared library will be available and instead this PR already contains the changes now. You can create the shared library after the changes in this PR (and the other PRs) are merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7809 +/- ##
==========================================
- Coverage 28.94% 28.80% -0.14%
==========================================
Files 1606 1615 +9
Lines 117652 118195 +543
Branches 50632 50746 +114
==========================================
Hits 34050 34050
- Misses 74481 75024 +543
Partials 9121 9121
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@esteve |
@mitsudome-r sure, no problem. However, the headers need to be moved anyway, either to a private location in |
Pull request was converted to draft
dcfebc0
to
9359e4f
Compare
…toware and rename package Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
471d5e7
to
a2f5d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the launchers?
$(find-pkg-share tracking_object_merger) -> $(find-pkg-share autoware_tracking_object_merger)
perception/autoware_tracking_object_merger/launch/decorative_tracker_merger.launch.xml
Show resolved
Hide resolved
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the launchers.
…toware and rename package (autowarefoundation#7809) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
…toware and rename package (autowarefoundation#7809) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
…toware and rename package (autowarefoundation#7809) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Signed-off-by: chtseng <chtseng@itri.org.tw>
…toware and rename package (autowarefoundation#7809) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Description
move headers to include/autoware and rename package
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.