fix(bvp): don't use numeric limits for start/finish distance #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/dont-use-numeric-limits
branch
from
94199f9 to
e153383
Compare
satoshi-ota
requested review from
shmpwk,
tkimura4,
rej55,
isamu-takagi,
soblin,
kosuke55,
kyoichi-sugahara,
takayuki5168 and
yuki-takagi-66
as code owners
rej55
reviewed
May 10, 2024
| @@ -72,8 +72,6 @@ void BlindSpotModuleManager::launchNewModules( | |||
| module_id, lane_id, planner_data_, planner_param_, logger_.get_child("blind_spot_module"), | |||
| clock_)); | |||
| generateUUID(module_id); | |||
| updateRTCStatus( | |||
| getUUID(module_id), true, std::numeric_limits<double>::lowest(), path.header.stamp); | |||
There was a problem hiding this comment.
If this line is removed, RTC status does not contain this information.
To check the existence of a module with module_id, status should contain this information, so I think this information including distance as -10000.0 is required.
|
@rej55 Thanks. I think there is no problem since On the other hand, I found it was able to echo topics that include nan or inf. Then, I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updateRTCStatus.std::numeric_limits<double>::lowest()for start/finish distance in order to avoid ros2 command crashing. pybind11 error during subscription take_message() when message has NaN value ros2/rclpy#848Tests performed
Effects on system behavior
Nothing.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.