Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bvp): don't use numeric limits for start/finish distance #6960

Closed
wants to merge 1 commit into from
+1 −12
Closed

fix(bvp): don't use numeric limits for start/finish distance #6960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions planning/behavior_velocity_blind_spot_module/src/manager.cpp
View file
Original file line number Diff line number Diff line change
@@ -72,8 +72,6 @@ void BlindSpotModuleManager::launchNewModules(
module_id, lane_id, planner_data_, planner_param_, logger_.get_child("blind_spot_module"),
clock_));
generateUUID(module_id);
updateRTCStatus(
getUUID(module_id), true, std::numeric_limits<double>::lowest(), path.header.stamp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this line is removed, RTC status does not contain this information.
To check the existence of a module with module_id, status should contain this information, so I think this information including distance as -10000.0 is required.

}
}

3 changes: 0 additions & 3 deletions planning/behavior_velocity_crosswalk_module/src/manager.cpp
View file
Original file line number Diff line number Diff line change
@@ -189,9 +189,6 @@ void CrosswalkModuleManager::launchNewModules(const PathWithLaneId & path)
node_, road_lanelet_id, crosswalk_lanelet_id, reg_elem_id, lanelet_map_ptr, p, logger,
clock_));
generateUUID(crosswalk_lanelet_id);
updateRTCStatus(
getUUID(crosswalk_lanelet_id), true, std::numeric_limits<double>::lowest(),
path.header.stamp);
};

const auto crosswalk_reg_elem_map = planning_utils::getRegElemMapOnPath<Crosswalk>(
2 changes: 0 additions & 2 deletions planning/behavior_velocity_detection_area_module/src/manager.cpp
View file
Original file line number Diff line number Diff line change
@@ -65,8 +65,6 @@ void DetectionAreaModuleManager::launchNewModules(
module_id, lane_id, *detection_area_with_lane_id.first, planner_param_,
logger_.get_child("detection_area_module"), clock_));
generateUUID(module_id);
updateRTCStatus(
getUUID(module_id), true, std::numeric_limits<double>::lowest(), path.header.stamp);
}
}
}
2 changes: 0 additions & 2 deletions planning/behavior_velocity_no_stopping_area_module/src/manager.cpp
View file
Original file line number Diff line number Diff line change
@@ -67,8 +67,6 @@ void NoStoppingAreaModuleManager::launchNewModules(
module_id, lane_id, *m.first, planner_param_, logger_.get_child("no_stopping_area_module"),
clock_));
generateUUID(module_id);
updateRTCStatus(
getUUID(module_id), true, std::numeric_limits<double>::lowest(), path.header.stamp);
}
}
}
2 changes: 1 addition & 1 deletion planning/behavior_velocity_planner_common/src/scene_module_interface.cpp
View file
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ SceneModuleInterface::SceneModuleInterface(
: module_id_(module_id),
activated_(false),
safe_(false),
distance_(std::numeric_limits<double>::lowest()),
distance_(-10000.0),
logger_(logger),
clock_(clock)
{
2 changes: 0 additions & 2 deletions planning/behavior_velocity_traffic_light_module/src/manager.cpp
View file
Original file line number Diff line number Diff line change
@@ -132,8 +132,6 @@ void TrafficLightModuleManager::launchNewModules(
module_id, lane_id, *(traffic_light_reg_elem.first), traffic_light_reg_elem.second,
planner_param_, logger_.get_child("traffic_light_module"), clock_));
generateUUID(module_id);
updateRTCStatus(
getUUID(module_id), true, std::numeric_limits<double>::lowest(), path.header.stamp);
}
}
}