Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ar_tag_based_localizer): added 1 second wait to test #6624

Merged

Conversation

SakodaShintaro
Copy link
Contributor

Description

Added a 1 second wait to the test to address the issue below.

#6619

Tests performed

It has been confirmed that the following command succeeds more than 200 times.

colcon test --packages-select ar_tag_based_localizer --event-handlers console_cohesion+

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 15, 2024
@SakodaShintaro SakodaShintaro self-assigned this Mar 15, 2024
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.78%. Comparing base (152b11e) to head (c29f8ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6624   +/-   ##
=======================================
  Coverage   14.78%   14.78%           
=======================================
  Files        1923     1923           
  Lines      132468   132469    +1     
  Branches    39363    39363           
=======================================
+ Hits        19586    19587    +1     
  Misses      91032    91032           
  Partials    21850    21850           
Flag Coverage Δ *Carryforward flag
differential 9.03% <100.00%> (?)
total 14.78% <ø> (ø) Carriedforward from 152b11e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro marked this pull request as ready for review March 15, 2024 08:23
@xmfcx xmfcx self-requested a review March 15, 2024 11:09
@xmfcx xmfcx merged commit 0625e4a into autowarefoundation:main Mar 18, 2024
34 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/add_waiting_to_artag_test branch March 19, 2024 00:03
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…ndation#6624)

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ndation#6624)

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants