fix(ar_tag_based_localizer): added 1 second wait to test #6624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
SakodaShintaro
added
the
run:build-and-test-differential
github-actions
bot
added
the
component:localization
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6624 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1923 1923
Lines 132468 132469 +1
Branches 39363 39363
=======================================
+ Hits 19586 19587 +1
Misses 91032 91032
Partials 21850 21850
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SakodaShintaro
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
TaikiYamada4 and
YamatoAndo
as code owners
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…ndation#6624) Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ndation#6624) Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a 1 second wait to the test to address the issue below.
#6619
Tests performed
It has been confirmed that the following command succeeds more than 200 times.
Effects on system behavior
There are no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.