-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shape_estimation): preserve irregular large size vehicle detected by camera_lidar_fusion as unknown #6598
fix(shape_estimation): preserve irregular large size vehicle detected by camera_lidar_fusion as unknown #6598
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6598 +/- ##
==========================================
+ Coverage 14.79% 14.92% +0.13%
==========================================
Files 1920 1915 -5
Lines 132349 131181 -1168
Branches 39339 39305 -34
==========================================
Hits 19578 19578
+ Misses 90935 89770 -1165
+ Partials 21836 21833 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please wait for this to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the issue is resolved, via the issue data replay and recompute.
Thank you.
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could you change variable name?
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please change autoware_launch before merge this.
@YoshiRi Since no shape_estimation releated parameters registered in autoware_launch so It's unneccessary. |
… by camera_lidar_fusion as unknown (autowarefoundation#6598) * fix(shape_estimation): keep excluded objects as unknown Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: add optional param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
… by camera_lidar_fusion as unknown (autowarefoundation#6598) * fix(shape_estimation): keep excluded objects as unknown Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: add optional param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
… by camera_lidar_fusion as unknown (autowarefoundation#6598) * fix(shape_estimation): keep excluded objects as unknown Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: add optional param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
… by camera_lidar_fusion as unknown (autowarefoundation#6598) * fix(shape_estimation): keep excluded objects as unknown Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: add optional param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: rename param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Description
Related Link
TIER IV INTERNAL LINK
Tests performed
Confirmed by logging_simulator with internal rosbag that the camera_lidar_fusion result of left-side crane detection (

/perception/object_recognition/detection/clustering/camera_lidar_fusion/objects
) has been improved.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.