Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointpainting): recovery default parameter #6460

Merged

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented Feb 20, 2024

Description

Score_threshold parameter is mistakenly modified by cc0b108, so I fixed it.

TIER IV INTERNAL LINK

Tests performed

I did not run autoware with this PR

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
@Shin-kyoto Shin-kyoto requested a review from ktro2828 February 20, 2024 11:47
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 20, 2024
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(read discussion)

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 20, 2024
@@ -26,7 +26,7 @@
iou_nms_target_class_names: ["CAR"]
iou_nms_search_distance_2d: 10.0
iou_nms_threshold: 0.1
score_threshold: 0.4
score_threshold: 0.35
Copy link
Contributor

@kminoda kminoda Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not related to this part) Would you mind modifying awf/autoware_launch as well?
https://github.com/autowarefoundation/autoware_launch/blob/b23c5f948421037d2bf81dd340015c4b2fd1602c/autoware_launch/config/perception/object_recognition/detection/lidar_model/pointpainting.param.yaml#L29

Or let me know if this is intentional to leave it as it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for this PR, isn't it better to first create a PR in awf/autoware_launch and then cherry-pick it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will make the PR to awf/autoware_launch!

@kminoda kminoda changed the title fix: recovery default parameter fix(pointpainting): recovery default parameter Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7dcc4e) 15.11% compared to head (4f2afe5) 15.09%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6460      +/-   ##
==========================================
- Coverage   15.11%   15.09%   -0.03%     
==========================================
  Files        1821     1826       +5     
  Lines      126171   126386     +215     
  Branches    38188    38187       -1     
==========================================
  Hits        19077    19077              
- Misses      85704    85919     +215     
  Partials    21390    21390              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.12% <ø> (+<0.01%) ⬆️ Carriedforward from f7dcc4e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shin-kyoto Shin-kyoto merged commit b4cd3b0 into autowarefoundation:main Feb 20, 2024
47 of 49 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants