-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pointpainting): recovery default parameter #6460
fix(pointpainting): recovery default parameter #6460
Conversation
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM(read discussion)
@@ -26,7 +26,7 @@ | |||
iou_nms_target_class_names: ["CAR"] | |||
iou_nms_search_distance_2d: 10.0 | |||
iou_nms_threshold: 0.1 | |||
score_threshold: 0.4 | |||
score_threshold: 0.35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not related to this part) Would you mind modifying awf/autoware_launch as well?
https://github.com/autowarefoundation/autoware_launch/blob/b23c5f948421037d2bf81dd340015c4b2fd1602c/autoware_launch/config/perception/object_recognition/detection/lidar_model/pointpainting.param.yaml#L29
Or let me know if this is intentional to leave it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for this PR, isn't it better to first create a PR in awf/autoware_launch and then cherry-pick it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will make the PR to awf/autoware_launch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6460 +/- ##
==========================================
- Coverage 15.11% 15.09% -0.03%
==========================================
Files 1821 1826 +5
Lines 126171 126386 +215
Branches 38188 38187 -1
==========================================
Hits 19077 19077
- Misses 85704 85919 +215
Partials 21390 21390
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Description
Score_threshold parameter is mistakenly modified by cc0b108, so I fixed it.
TIER IV INTERNAL LINK
Tests performed
I did not run autoware with this PR
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.