Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointpainting): recovery default parameter #6460

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(pointpainting): recovery default parameter #6460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion perception/image_projection_based_fusion/config/pointpainting.param.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
iou_nms_target_class_names: ["CAR"]
iou_nms_search_distance_2d: 10.0
iou_nms_threshold: 0.1
score_threshold: 0.4
score_threshold: 0.35
Copy link
Contributor

@kminoda kminoda Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not related to this part) Would you mind modifying awf/autoware_launch as well?
https://github.com/autowarefoundation/autoware_launch/blob/b23c5f948421037d2bf81dd340015c4b2fd1602c/autoware_launch/config/perception/object_recognition/detection/lidar_model/pointpainting.param.yaml#L29

Or let me know if this is intentional to leave it as it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for this PR, isn't it better to first create a PR in awf/autoware_launch and then cherry-pick it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will make the PR to awf/autoware_launch!

omp_params:
# omp params
num_threads: 1
Loading