Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): fix marker color #6458

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 20, 2024

Description

related PR: #6447

fix unexpected marker color.

Screenshot from 2024-02-20 16-24-54

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 20, 2024
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 20, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) February 20, 2024 07:31
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you I was inverting the colour.
#6447

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (757d656) 15.12% compared to head (9da421a) 15.12%.
Report is 3 commits behind head on main.

Files Patch % Lines
...n_planner/src/lanelet2_plugins/default_planner.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6458   +/-   ##
=======================================
  Coverage   15.12%   15.12%           
=======================================
  Files        1821     1821           
  Lines      126131   126131           
  Branches    38180    38180           
=======================================
  Hits        19073    19073           
  Misses      85670    85670           
  Partials    21388    21388           
Flag Coverage Δ *Carryforward flag
differential 12.91% <0.00%> (?)
total 15.12% <ø> (+<0.01%) ⬆️ Carriedforward from 757d656

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit d73d0f6 into autowarefoundation:main Feb 20, 2024
38 of 40 checks passed
@satoshi-ota satoshi-ota deleted the fix/mission-marker branch February 20, 2024 09:29
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants