Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner_rviz_plugin): create mission planner tool #6362

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 8, 2024

Description

Add rviz plugin to set/clear the mrm route.
Screenshot from 2024-02-08 22-11-18

Related links

Tests performed

Same as #6363.

https://evaluation.tier4.jp/evaluation/reports/7d8458ad-5132-5f28-b0b2-1c117bc1b7e6?project_id=prd_jt

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 8, 2024
@isamu-takagi isamu-takagi changed the title feat(mission_planner_rviz_plugin): create package feat(mission_planner_rviz_plugin): create mission planner tool Feb 8, 2024
@isamu-takagi isamu-takagi self-assigned this Feb 8, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review February 8, 2024 13:10
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 21, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 21, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (e329fda) 15.24% compared to head (16f70c5) 15.23%.
Report is 26 commits behind head on main.

Files Patch % Lines
...n_planner_rviz_plugin/src/route_selector_panel.cpp 0.00% 78 Missing ⚠️
...ommon/mission_planner_rviz_plugin/src/mrm_goal.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6362      +/-   ##
==========================================
- Coverage   15.24%   15.23%   -0.02%     
==========================================
  Files        1816     1818       +2     
  Lines      125147   125233      +86     
  Branches    38188    38188              
==========================================
  Hits        19075    19075              
- Misses      84684    84770      +86     
  Partials    21388    21388              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.24% <ø> (ø) Carriedforward from e329fda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit 13bd153 into autowarefoundation:main Feb 21, 2024
20 of 23 checks passed
@isamu-takagi isamu-takagi deleted the feat/mrm-route-rviz-plugin branch February 21, 2024 18:35
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…arefoundation#6362)

* feat(mission_planner_rviz_plugin): create package

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix copyright

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add interrupted state

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* use full license text instead of spdx

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* feat(mission_planner_rviz_plugin): create package

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix copyright

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add interrupted state

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* use full license text instead of spdx

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…arefoundation#6362)

* feat(mission_planner_rviz_plugin): create package

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix copyright

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add interrupted state

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* use full license text instead of spdx

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants