Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): apply route_selector #6364

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 8, 2024

Description

Apply interface changes from #6363.

Related links

Tests performed

  1. Merge the dependent PRs.
  2. Launch planning simulator.
  3. Check if the route can be set.

https://evaluation.tier4.jp/evaluation/reports/7d8458ad-5132-5f28-b0b2-1c117bc1b7e6?project_id=prd_jt

Notes for reviewers

None

Interface changes

Same as #6363.

Effects on system behavior

The MRM route will no longer be reflected in AD API.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 8, 2024
@isamu-takagi isamu-takagi changed the title feat(default_ad_api): apply route_selector feat(default_ad_api)!: apply route_selector Feb 8, 2024
@isamu-takagi isamu-takagi changed the title feat(default_ad_api)!: apply route_selector feat(default_ad_api): apply route_selector Feb 8, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review February 8, 2024 12:58
@isamu-takagi isamu-takagi self-assigned this Feb 8, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) February 21, 2024 18:36
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (86b4335) 15.09% compared to head (6f1d3e7) 15.13%.
Report is 2 commits behind head on main.

Files Patch % Lines
system/default_ad_api/src/routing.cpp 2.12% 39 Missing and 7 partials ⚠️
...stem/default_ad_api/src/utils/route_conversion.cpp 0.00% 34 Missing ⚠️
...stem/default_ad_api/src/utils/route_conversion.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6364      +/-   ##
==========================================
+ Coverage   15.09%   15.13%   +0.03%     
==========================================
  Files        1823     1824       +1     
  Lines      126342   126075     -267     
  Branches    38200    38212      +12     
==========================================
- Hits        19077    19076       -1     
+ Misses      85871    85609     -262     
+ Partials    21394    21390       -4     
Flag Coverage Δ *Carryforward flag
differential 15.35% <1.20%> (?)
total 15.13% <ø> (+0.04%) ⬆️ Carriedforward from 86b4335

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit 1ed6fac into autowarefoundation:main Feb 21, 2024
22 of 23 checks passed
@isamu-takagi isamu-takagi deleted the feat/adapi-apply-route-selector branch February 21, 2024 22:12
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
* feat(default_ad_api): apply route_selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add interrupted state

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix initializing state handling

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* feat(default_ad_api): apply route_selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add interrupted state

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix initializing state handling

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat(default_ad_api): apply route_selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add interrupted state

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix initializing state handling

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants