-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(default_ad_api): apply route_selector #6364
feat(default_ad_api): apply route_selector #6364
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6364 +/- ##
==========================================
+ Coverage 15.09% 15.13% +0.03%
==========================================
Files 1823 1824 +1
Lines 126342 126075 -267
Branches 38200 38212 +12
==========================================
- Hits 19077 19076 -1
+ Misses 85871 85609 -262
+ Partials 21394 21390 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* feat(default_ad_api): apply route_selector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add interrupted state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix initializing state handling Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
* feat(default_ad_api): apply route_selector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add interrupted state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix initializing state handling Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* feat(default_ad_api): apply route_selector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add interrupted state Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix initializing state handling Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Description
Apply interface changes from #6363.
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/7d8458ad-5132-5f28-b0b2-1c117bc1b7e6?project_id=prd_jt
Notes for reviewers
None
Interface changes
Same as #6363.
Effects on system behavior
The MRM route will no longer be reflected in AD API.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.