Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perception): refactor perception launch #10186

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

chore

fa35e9e
Select commit
Loading
Failed to load commit list.
Open

chore(perception): refactor perception launch #10186

chore
fa35e9e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 10, 2025 in 46s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Large Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
traffic_light_node_container.launch.py 1 advisory rule 8.76 → 8.65 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method traffic_light_node_container.launch.py: create_traffic_light_node_container

Annotations

Check warning on line 318 in launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light_node_container.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

create_traffic_light_node_container increases from 233 to 256 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.