-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(perception): refactor perception launch #10186
base: main
Are you sure you want to change the base?
chore(perception): refactor perception launch #10186
Conversation
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10186 +/- ##
==========================================
+ Coverage 26.24% 26.43% +0.19%
==========================================
Files 1378 1389 +11
Lines 107415 107567 +152
Branches 41411 41417 +6
==========================================
+ Hits 28189 28434 +245
+ Misses 76412 76302 -110
- Partials 2814 2831 +17
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- I confirmed that this PR is good enough to merge.
- I did NOT check this PR by running autoware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for autoware_tensorrt_yolox
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Overall
Refactoring the launcher around TLR pipeline.
model_path
,model_name
andlabel_name
tomodel_path
andlabel_path
) in ml packages for easy to understand on upper layer. There is limit to decompose variable caused by representation abillity of variable. (variable will be duplicated.)model_path
andlabel_path
from param file to launch file, because need to decide uniquely if there are variable like$(var hoge)
in param file. It is not scalable and continuous.autoware_launch
.For
tier4_perception_launch
owner1., 2., 4., and 6. is relevant.
For
tier4_simulator_launch
ownerFor
*traffic_light*
owner2., 3., and 4. is relevant.
For
autoware_tensorrt_yolox
ownerFor around
autoware_launch
owner1., 2., 4., and 5. is relevant.
Related links
autowarefoundation/autoware_launch#1336
How was this PR tested?
Overall
I checked this PR on Evaluator. (https://evaluation.ci.tier4.jp/evaluation/reports/d21cf15a-0d5d-5056-beec-0d99e3e8fd09?project_id=prd_jt)
tier4_simulator_launch
I checked this PR works with
Passed
on console under below command.Screencast.from.03-01-2025.06.53.54.PM.webm
*traffic_light*
You can see above Evaluator link.
autoware_tensorrt_yolox
I checked this PR works under below command.
Notes for reviewers
None.
Interface changes
None, but move the parameter definition place from param file to launch file.
Effects on system behavior
None.