Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #974

Open
wants to merge 74 commits into
base: 18.0
Choose a base branch
from
Open

[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #974

wants to merge 74 commits into from
+6,206 −23

Conversation

StephaneMangin
Copy link

@StephaneMangin StephaneMangin commented Feb 10, 2025 •
edited
Loading

Includes:

  • reusing of "delivery.carrier.template.option" from OCA module "delivery_carrier_option"
  • reusing of "shipping.label" from OCA module "delivery_carrier_shipping_label" instead of custom "postlogistics.shipping.label"
  • Add a default package type to fullfill postlogistics_send_shipping requirements (Using ECO default shipping pricing)

Depends on:

To avoid Odoo external URL calls restriction, decorate your test class with @common.tagged("-standard") (removing the standard tag which is by default). This way, Odoo doesn't patch the request.Session.send method to throw an exception in an external URL call case.

@StephaneMangin
Copy link
Author

Superseeds #940

This was referenced Feb 10, 2025
Closed
Open
@StephaneMangin StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 5 times, most recently from 98eb1c9 to 4d44284 Compare February 10, 2025 14:52
@yankinmax
Copy link
Contributor

hello @StephaneMangin
There is an issue in migration. You're overriding the selection of the type field declared for delivery.carrier.template.option model in delivery_carrier_option module.
Here is Odoo logs:

WARNING testdb odoo.fields: delivery.carrier.template.option.type: selection=[('label_layout', 'Label Layout'), ('output_format', 'Output Format'), ('resolution', 'Output Resolution'), ('basic', 'Basic Service'), ('additional', 'Additional Service'), ('delivery', 'Delivery Instructions'), ('partner_option', 'Partner Option')] overrides existing selection; use selection_add instead

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_postlogistics

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 14, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 14, 2025
Open
23 tasks
@yankinmax yankinmax mentioned this pull request Feb 14, 2025
Open
3 tasks
jbaudoux
jbaudoux reviewed Feb 14, 2025
View reviewed changes
@bizzappdev bizzappdev mentioned this pull request Feb 17, 2025
Open
bizzappdev
bizzappdev reviewed Feb 17, 2025
View reviewed changes
@StephaneMangin
Copy link
Author

hello @StephaneMangin There is an issue in migration. You're overriding the selection of the type field declared for delivery.carrier.template.option model in delivery_carrier_option module. Here is Odoo logs:

WARNING testdb odoo.fields: delivery.carrier.template.option.type: selection=[('label_layout', 'Label Layout'), ('output_format', 'Output Format'), ('resolution', 'Output Resolution'), ('basic', 'Basic Service'), ('additional', 'Additional Service'), ('delivery', 'Delivery Instructions'), ('partner_option', 'Partner Option')] overrides existing selection; use selection_add instead

Yes it is transitional, because these values are added in a dependency. Updating...

@StephaneMangin StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 4 times, most recently from 3fe8f87 to 78c780f Compare February 18, 2025 14:15
@StephaneMangin StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 2 times, most recently from 0f171db to 894894d Compare February 21, 2025 14:29
@StephaneMangin StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 3 times, most recently from e9dc13c to 0b24d58 Compare February 26, 2025 13:58
oca-ci and others added 18 commits March 18, 2025 10:29
@StephaneMangin
[UPD] Update delivery_postlogistics.pot
c2455ae
@OCA-git-bot @StephaneMangin
[BOT] post-merge updates
4cc4e87
@weblate @StephaneMangin
Update translation files
bac5b92 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
@grindtildeath @StephaneMangin
[FIX] delivery_postlogistics: Change sender limit to 25 chars
3dd4a53 
Postlogistics limit for fields such as name, street and city,
is 35 chars for the recipient fields but is limited to 25 characters.
@OCA-git-bot @StephaneMangin
[BOT] post-merge updates
ec4a360
@ajaniszewska-dev @StephaneMangin
[FIX] delivery_postlogistics: raise exception when no token received
869be8a 
Sometimes due to API error it may happen we don't receive anything back when requesting token.
In this case we want to show meaningful message.
@StephaneMangin
[UPD] Update delivery_postlogistics.pot
29203ab
@OCA-git-bot @StephaneMangin
[BOT] post-merge updates
936f605
@weblate @StephaneMangin
Update translation files
ac1a10f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
@guewen @StephaneMangin
Fix access to not-existing record self after rollback
2aae8b5 
If a stock.picking is created and in the same transaction we generate
a label, when the webservice returns an error, the module rollbacks
the transaction, so 'self' is empty and will fail with:

Record does not exist or has been deleted. (Record:
stock.picking(8211067,), User: 6)

When trying to write the tracking number, and will therefore not
raise the details of the error.
@sebalix @StephaneMangin
delivery_postlogistics: improve rendering of error messages
edc7146
@sebalix @StephaneMangin
delivery_postlogistics: fix 'sanitize_strings' to always return strings
c0e5b2a
@sebalix @StephaneMangin
[FIX] delivery_postlogistics: hide key secret on view
f2f4d47
@henrybackman @StephaneMangin
delivery_postlogistics: fix test sanitize values
9b5a1a5 
The tests from d5c3f73 failed due to partner city being required
@StephaneMangin
[UPD] Update delivery_postlogistics.pot
1991b9a
@OCA-git-bot @StephaneMangin
[BOT] post-merge updates
567d8b2
@weblate @StephaneMangin
Update translation files
c800dab 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
@bizzappdev @StephaneMangin
[IMP] delivery_postlogistics: pre-commit auto fixes
d451805
@StephaneMangin StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 7 times, most recently from 22b6efe to cc1636f Compare March 18, 2025 13:06
@StephaneMangin StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch from cc1636f to 683d7fa Compare March 18, 2025 13:14
leemannd
leemannd reviewed Mar 18, 2025
View reviewed changes
delivery_postlogistics/models/delivery_carrier.py
res["postlogistics_default_package_type_id"] = self.env.ref(
"delivery_postlogistics.postlogistics_default_package_type",
raise_if_not_found=False,
).id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raise_if_not_found will raise a Nonetype if the xmlid is not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd left review comments

@jbaudoux jbaudoux Awaiting requested review from jbaudoux

@imlopes imlopes Awaiting requested review from imlopes

@yankinmax yankinmax Awaiting requested review from yankinmax

@bizzappdev bizzappdev Awaiting requested review from bizzappdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.