-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] delivery_carrier_label_batch: Migration to 18.0 #984
Open
yankinmax
wants to merge
61
commits into
OCA:18.0
Choose a base branch
from
camptocamp:18.0-mig-delivery_carrier_label_batch
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] delivery_carrier_label_batch: Migration to 18.0 #984
yankinmax
wants to merge
61
commits into
OCA:18.0
from
camptocamp:18.0-mig-delivery_carrier_label_batch
+2,859
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are failing because of the issue I've mentioned in this PR ( |
imlopes
approved these changes
Feb 16, 2025
/ocabot migration delivery_carrier_label_batch |
a17288a
to
dd119da
Compare
vvrossem
approved these changes
Feb 20, 2025
39b2255
to
ca31b7c
Compare
- change name to batch to match with change of `picking_dispatch` name to `stock_batch_picking` - mode description in README.rst - move files in models and views directories - change headers to small license header - use api 8.0 - fix and improve tests
the field has been renamed in the base module
Probably due to usage of multiple environment and cache. datas can't be read from shipping.label but it can be read from ir.attachment
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_carrier_label_batch Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_carrier_label_batch/
The threading option doesn't work in test mode but was not tested because labels were already generated in the test. Using a condition to use different threads only when test mode is not activated allows to test label generation.
Co-authored-by: Hai Lang <hailn@trobz.com>
Sometimes, when regenerating labels from third party API, we could not get the new tracking references. And then as we do not purge tracking references correctly, previous ones are kept and lead to incoherences (batch picking tracking references emptied but labels still existing). For this we need to manually purge references when asking for full regeneration.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_label_batch Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_label_batch/
Currently translated at 2.8% (1 of 35 strings) Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_label_batch Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_label_batch/es/
Currently translated at 100.0% (35 of 35 strings) Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_label_batch Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_label_batch/es/
ca31b7c
to
e3888d0
Compare
Ricardoalso
reviewed
Feb 24, 2025
e3888d0
to
823ed3d
Compare
Ricardoalso
approved these changes
Feb 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: