Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] delivery_postlogistics_dangerous_goods: Migration to 18.0 #941

Open
wants to merge 12 commits into
base: 18.0
Choose a base branch
from

Conversation

bizzappdev
Copy link

@bizzappdev bizzappdev commented Jan 28, 2025

Dependency MR for module l10n_eu_product_adr_dangerous_goods OCA/community-data-files#211

Dependency MR for module delivery_postlogistics #974

@bizzappdev bizzappdev force-pushed the 18.0-mig-delivery_postlogistics_dangerous_goods-BAD branch 3 times, most recently from 4cf732f to 7c767f0 Compare January 28, 2025 11:16
@bizzappdev bizzappdev marked this pull request as ready for review February 5, 2025 07:45
@@ -30,6 +30,7 @@ def setUpClassWebservice(cls):
cls.service_class = PostlogisticsWebServiceDangerousGoods(
cls.env.user.company_id
)
return None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the same without it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return will be needed as we are calling super, else pre-commit will fail.
So, we return the super result now.

@bizzappdev bizzappdev marked this pull request as draft February 5, 2025 14:41
@bizzappdev bizzappdev force-pushed the 18.0-mig-delivery_postlogistics_dangerous_goods-BAD branch from 7c767f0 to f8e50f0 Compare February 6, 2025 06:45
@bizzappdev bizzappdev marked this pull request as ready for review February 6, 2025 06:47
@rousseldenis
Copy link
Contributor

/ocabot migration delivery_postlogistics_dangerous_goods

@bizzappdev bizzappdev force-pushed the 18.0-mig-delivery_postlogistics_dangerous_goods-BAD branch from f8e50f0 to fc34c3a Compare February 10, 2025 05:40
@bizzappdev bizzappdev force-pushed the 18.0-mig-delivery_postlogistics_dangerous_goods-BAD branch from fc34c3a to 1d445f5 Compare February 17, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants