[18][ADD/MIG] delivery_carrier_option (extracted from base_delivery_carrier_label module) #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-dacosta
force-pushed
the
18-add-delivery_carrier_option
branch
from
104555e to
080a8c0
Compare
StephaneMangin
approved these changes
Feb 10, 2025
StephaneMangin
approved these changes
Feb 10, 2025
delivery_carrier_option/views/delivery_carrier_template_option.xml
Outdated
Show resolved
Hide resolved
|
cc @florian-dacosta What do you think ? |
leemannd
approved these changes
Feb 10, 2025
|
This PR has the |
Co-authored-by: Stéphane Mangin <StephaneMangin@users.noreply.github.com>
florian-dacosta
force-pushed
the
18-add-delivery_carrier_option
branch
from
efc47e5 to
c3e3b2d
Compare
vvrossem
reviewed
Feb 12, 2025
delivery_carrier_option/models/delivery_carrier_template_option.py
Outdated
Show resolved
Hide resolved
delivery_carrier_option/models/delivery_carrier_template_option.py
Outdated
Show resolved
Hide resolved
delivery_carrier_option/views/delivery_carrier_template_option.xml
Outdated
Show resolved
Hide resolved
delivery_carrier_option/views/delivery_carrier_template_option.xml
Outdated
Show resolved
Hide resolved
delivery_carrier_option/views/delivery_carrier_template_option.xml
Outdated
Show resolved
Hide resolved
3 tasks
Co-authored-by: vvrossem <vvrossem@gmail.com>
|
Hello @vvrossem I've included all your suggestions |
hparfr
approved these changes
Feb 20, 2025
vvrossem
approved these changes
Feb 21, 2025
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 5ffb1dc. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should have been done a long time ago IMO
It is a clear independent feature from base_delivery_carrier_label and all carriers don't necessarly needs it.