[14.0][FIX] delivery_send_to_shipper_at_operation: Keep delivery_notification_sent set on backorder

[mt-software-de]

If a backorder is created out of a transfer which is marked as delivery_notification_sent = True.
The backorder should also be marked as delivery_notification_sent.

@jbaudoux @TDu

Depends on:
Fixing tests
#786

[jbaudoux]

Why can't we simply revert this #720 ?

[mt-software-de]

Why can't we simply revert this #720 ?

No it is fine to not copy the value, because move_dest_ids/move_orig_ids will also not copied from a move.
In a backorder case the move_orig_ids will be the same as in the new backorder

[jbaudoux]

@mt-software-de I should have added a unittest for my fix #720. If you do a partial pack, then you don't want to keep delivery_notification_sent on the pack backorder.
So, it's a bit more complex...

[mt-software-de]

@mt-software-de I should have added a unittest for my fix #720. If you do a partial pack, then you don't want to keep delivery_notification_sent on the pack backorder. So, it's a bit more complex...

For the pack operation backorder it is fine, to not set the delivery_notification_sent
therefore we need to remove

delivery-carrier/delivery_send_to_shipper_at_operation/models/stock_picking.py

Line 54 in 1ec5420

self.delivery_notification_sent = True

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[mt-software-de]

@jbaudoux could you please add the label "no stale". This is waiting for #786 or #854.

[mt-software-de]

@jbaudoux could you please add the label "no stale". This is waiting for #786 or #854.

Since there is no real progress, i added the context value set_default_package from base_delivery_carrier_label, this ensures the tests are working. This could be undone when the mentioned PR's are done.

@jbaudoux @i-vyshnevska

[jbaudoux]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-782-by-jbaudoux-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at aaee65a. Thanks a lot for contributing to OCA. ❤️