update

Author: mt-software-de

delivery_send_to_shipper_at_operation/models/stock_picking.py

@@ -52,7 +52,6 @@ def _handle_send_to_shipper_at_operation(self):
                 self.with_context(skip_delivery_cost=True).send_to_shipper()
                 # Flag the current operation and the ship one.
                 # Mandatory to not execute twice 'send_to_shipper' method
-                self.delivery_notification_sent = True
                 related_ship.delivery_notification_sent = True
                 related_ship.carrier_price = self.carrier_price
                 if not related_ship.carrier_tracking_ref:

delivery_send_to_shipper_at_operation/tests/test_send_to_shipper.py

@@ -206,6 +206,30 @@ def test_picking_fields_view_get(self):
         attrs = safe_eval(attrs_str)
         self.assertIn(("delivery_notification_sent", "=", True), attrs["invisible"])
 
+    def test_send_to_shipper_on_partial_pack(self):
+        """Check if a backorder of a transfer, where the delivery notification is already sent
+        keeps the delivery notification sent set.
+        """
+        with mock.patch.object(
+            type(self.carrier_on_pack),
+            "send_shipping",
+            return_value=SEND_SHIPPING_RETURN_VALUE,
+        ):
+            self.shipping.carrier_id = self.carrier_on_pack
+            self._validate_picking(self.picking)
+            pack_backorder = self._validate_picking(self.packing, 5)
+            self.assertTrue(self.shipping.delivery_notification_sent)
+            self.assertFalse(pack_backorder.delivery_notification_sent)
+            self._validate_picking(pack_backorder, 5)
+            self.assertTrue(self.shipping.delivery_notification_sent)
+            backorder = self._validate_picking(self.shipping, 5)
+            self.assertEqual(self.shipping.state, "done")
+            self.assertTrue(self.shipping.delivery_notification_sent)
+            self.assertTrue(backorder.delivery_notification_sent)
+            backorder2 = self._validate_picking(backorder, 5)
+            self.assertFalse(backorder2)
+            self.assertTrue(backorder.delivery_notification_sent)
+
     def test_send_to_shipper_on_pack_partial_shipping(self):
         """Check if a backorder of a transfer, where the delivery notification is already sent
         keeps the delivery notification sent set.