-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] delivery_driver: Flag driver in partner #774
Conversation
Hi @rafaelbn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
question: mapped should contain move_dest_ids
(o2m > o2m)?
1b14804
to
e31fb76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some blocking issues.
- When a driver is assigned in a shipping method, the partner is marked as a driver. - Unmarking partners as drivers is not allowed if it is associated with a sending method. - In pickings and move lines add domain in driver. Only partners marked as driver. - When selecting a partner driver, only the name of the partner is displayed. MT-5232 @moduon
e31fb76
to
221fdb3
Compare
This PR has the |
@rafaelbn please review and merge if it is ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 weeks PR 1 week in prod and tested un staging!
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 462965c. Thanks a lot for contributing to OCA. ❤️ |
Regression from OCA#774: ``` File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate env["carrier.driver"] File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__ return self.registry[model_name](self, (), ()) File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__ return self.models[model_name] KeyError: 'carrier.driver' Error: 'carrier.driver' ``` @moduon MT-5232
Regression from OCA#774: ``` File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate env["carrier.driver"] File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__ return self.registry[model_name](self, (), ()) File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__ return self.models[model_name] KeyError: 'carrier.driver' Error: 'carrier.driver' ``` @moduon MT-5232
Regression from OCA#774: ``` File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate env["carrier.driver"] File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__ return self.registry[model_name](self, (), ()) File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__ return self.models[model_name] KeyError: 'carrier.driver' Error: 'carrier.driver' ``` @moduon MT-5232
Regression from OCA#774: ``` File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate env["carrier.driver"] File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__ return self.registry[model_name](self, (), ()) File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__ return self.models[model_name] KeyError: 'carrier.driver' Error: 'carrier.driver' ``` @moduon MT-5232
MT-5232 @moduon
@rafaelbn @yajo @Shide @Gelojr please review.