Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] delivery_driver: Flag driver in partner #774

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

EmilioPascual
Copy link
Contributor

  • When a driver is assigned in a shipping method, the partner is marked as a driver.
  • Unmarking partners as drivers is not allowed if it is associated with a sending method.
  • In pickings and move lines add domain in driver. Only partners marked as driver.
  • When selecting a partner driver, only the name of the partner is displayed.
  • If driver is changed in picking, also it's changed in origin picking (if you activated multi-steps routes)

MT-5232 @moduon

@rafaelbn @yajo @Shide @Gelojr please review.

@OCA-git-bot
Copy link
Contributor

Hi @rafaelbn,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

question: mapped should contain move_dest_ids (o2m > o2m)?

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some blocking issues.

- When a driver is assigned in a shipping method, the partner is marked as a driver.
- Unmarking partners as drivers is not allowed if it is associated with a sending method.
- In pickings and move lines add domain in driver. Only partners marked as driver.
- When selecting a partner driver, only the name of the partner is displayed.

MT-5232 @moduon
@EmilioPascual EmilioPascual force-pushed the 16.0-imp-flag_driver_in_partner branch from e31fb76 to 221fdb3 Compare February 29, 2024 14:46
@EmilioPascual EmilioPascual requested a review from yajo February 29, 2024 14:47
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@EmilioPascual
Copy link
Contributor Author

@rafaelbn please review and merge if it is ok

@rafaelbn rafaelbn added this to the 16.0 milestone Mar 12, 2024
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 weeks PR 1 week in prod and tested un staging!

@rafaelbn
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-774-by-rafaelbn-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 967827b into OCA:16.0 Mar 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 462965c. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-imp-flag_driver_in_partner branch March 14, 2024 07:29
yajo added a commit to moduon/delivery-carrier that referenced this pull request Mar 14, 2024
Regression from OCA#774:

```

  File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate
    env["carrier.driver"]
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__
    return self.registry[model_name](self, (), ())
  File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__
    return self.models[model_name]
KeyError: 'carrier.driver'
Error: 'carrier.driver'
```

@moduon MT-5232
yajo added a commit to moduon/delivery-carrier that referenced this pull request Mar 14, 2024
Regression from OCA#774:

```

  File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate
    env["carrier.driver"]
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__
    return self.registry[model_name](self, (), ())
  File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__
    return self.models[model_name]
KeyError: 'carrier.driver'
Error: 'carrier.driver'
```

@moduon MT-5232
BhaveshHeliconia pushed a commit to HeliconiaIO/delivery-carrier that referenced this pull request Feb 6, 2025
Regression from OCA#774:

```

  File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate
    env["carrier.driver"]
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__
    return self.registry[model_name](self, (), ())
  File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__
    return self.models[model_name]
KeyError: 'carrier.driver'
Error: 'carrier.driver'
```

@moduon MT-5232
BhaveshHeliconia pushed a commit to HeliconiaIO/delivery-carrier that referenced this pull request Feb 7, 2025
Regression from OCA#774:

```

  File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate
    env["carrier.driver"]
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__
    return self.registry[model_name](self, (), ())
  File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__
    return self.models[model_name]
KeyError: 'carrier.driver'
Error: 'carrier.driver'
```

@moduon MT-5232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants