Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] delivery_driver_stock_picking_batch: Show only name in drivers #775

Merged
merged 1 commit into from
Mar 14, 2024
Merged

[IMP] delivery_driver_stock_picking_batch: Show only name in drivers #775

merged 1 commit into from
Mar 14, 2024

Conversation

EmilioPascual
Copy link
Contributor

@EmilioPascual EmilioPascual commented Feb 28, 2024 •
edited
Loading

  • Assign the driver's user in batch if batch isn't wave.
  • Show only name in drivers

PR Series: #774 (must be merged before this one)

MT-5232 @moduon

@Shide @rafaelbn please review

@rafaelbn rafaelbn added this to the 16.0 milestone Mar 12, 2024
@rafaelbn
Copy link
Member

rafaelbn commented Mar 12, 2024 •
edited
Loading

Example:

  • We have our own 16 trucks for delivery
  • We have our clients that sometime wants more and sometimes less, so every client has its delivery method.
  • But if a Delivery method has few kilos, the we join in the same batch different delivery method.
  • One (1) single drivers make that in 1 truck.
  • Automatically assigned is the first but this could be changed later.

😄

@EmilioPascual EmilioPascual force-pushed the 16.0-imp-delivery_driver_picking_batch branch from d74dc49 to 8d46ec2 Compare March 13, 2024 11:33
@EmilioPascual
Copy link
Contributor Author

@rafaelbn although you are right, I think the functionality may be controversial and not suitable for all workflows. I have decided to move the functionality to our repository.

@EmilioPascual
Copy link
Contributor Author

Failed tests are for another module: https://github.com/OCA/delivery-carrier/actions/runs/8263936917/job/22606437935?pr=775#step:8:335

rafaelbn
rafaelbn approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge in my side 👍🏼

@rafaelbn although you are right, I think the functionality may be controversial and not suitable for all workflows. I have decided to move the functionality to our repository.

Perfect.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@EmilioPascual
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-775-by-EmilioPascual-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e319ab1 into OCA:16.0 Mar 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b635dd2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@Shide Shide Shide approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EmilioPascual @rafaelbn @OCA-git-bot @Shide @rousseldenis