-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] delivery_driver: wrong model name #783
Conversation
Regression from OCA#774: ``` File "/opt/odoo/auto/addons/delivery_driver/migrations/16.0.1.0.1/post-migration.py", line 15, in migrate env["carrier.driver"] File "/opt/odoo/custom/src/odoo/odoo/api.py", line 549, in __getitem__ return self.registry[model_name](self, (), ()) File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 190, in __getitem__ return self.models[model_name] KeyError: 'carrier.driver' Error: 'carrier.driver' ``` @moduon MT-5232
Hi @EmilioPascual, @rafaelbn, |
Tests are failing because of that sh... CTTExpress module |
It seems one of those cases where a unit test has been confused with a monitoring tool. Now what? This issue is pretty critical... |
The test in CTT is not intended for monitoring, but for assuring that the API doesn't change and the module stops to work. Mocking that will lead to fail in that case but green CIs. Anyway, it's true that the demo environment against the tests is done is a bit unstable, but it's usually question of minutes. You can meanwhile add the PR in your deployment, as it's not critical, as it doesn't affect any new installation nor anyone not using the module. |
/ocabot merge |
Hi @EmilioPascual. Your command failed:
Ocabot commands
More information
|
In ten years, we'll laugh about that around a drink 😃 But, as already said, that one deserves a separate repo to not bother other people testing flows. |
/ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 5180e6f. Thanks a lot for contributing to OCA. ❤️ |
I think we need a guideline about flaky tests, so here's my proposal: OCA/odoo-community.org#158 |
Regression from #774:
@moduon MT-5232