{AKS} Support reset default value for loadbalancer profile and natgateway profile #28273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinForReal
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @MartinForReal, |
️✔️AzureCLI-BreakingChangeTest
|
|
AKS |
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
3 tasks
FumingZhang
reviewed
Jan 31, 2024
yanzhudd
approved these changes
Jan 31, 2024
|
CLI is on a release process and codes cannot be merged into the main repo. After we finish the release, will merge it. |
|
Hi @MartinForReal |
jiasli
reviewed
Feb 26, 2024
Comment on lines
+627
to
+628
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2023-11-01 |
There was a problem hiding this comment.
This PR adds 2 GET requests and 1 PUT request for https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002
#28407 (merged on 2024-02-21) bumped the API version of /providers/Microsoft.ContainerService/managedClusters from 2023-11-01 to 2024-01-01 in the existing requests.
This PR's CI was run on 2024-01-30 and passed, but it is not re-run after #28407. As adding new lines won't cause merge conflict, this PR can be merged, but triggers CI failure after merging:
2024-02-26T08:30:09.3934011Z except CannotOverwriteExistingCassetteException as ex:
2024-02-26T08:30:09.3934190Z > raise AssertionError(ex)
2024-02-26T08:30:09.3934901Z E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_loadbalancer_then_update.yaml') in your current record mode ('once').
2024-02-26T08:30:09.3935712Z E No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2024-01-01>) was found.
2024-02-26T08:30:09.3936084Z E Found 4 similar requests with 0 different matcher(s) :
2024-02-26T08:30:09.3936233Z E
2024-02-26T08:30:09.3936782Z E 1 - (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2024-01-01>).
2024-02-26T08:30:09.3937361Z E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path', '_custom_request_query_matcher']
2024-02-26T08:30:09.3937574Z E Matchers failed :
2024-02-26T08:30:09.3937698Z E
2024-02-26T08:30:09.3938257Z E 2 - (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2024-01-01>).
2024-02-26T08:30:09.3938785Z E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path', '_custom_request_query_matcher']
2024-02-26T08:30:09.3938994Z E Matchers failed :
2024-02-26T08:30:09.3939120Z E
2024-02-26T08:30:09.3939687Z E 3 - (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2024-01-01>).
2024-02-26T08:30:09.3940242Z E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path', '_custom_request_query_matcher']
2024-02-26T08:30:09.3940465Z E Matchers failed :
2024-02-26T08:30:09.3940591Z E
2024-02-26T08:30:09.3941175Z E 4 - (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2024-01-01>).
2024-02-26T08:30:09.3941718Z E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path', '_custom_request_query_matcher']
2024-02-26T08:30:09.3941942Z E Matchers failed :
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks update --load-balancer-outbound-ports 0Description
related: #27071
allow customer to set --load-balancer-outbound-ports, --nat-gateway-managed-outbound-ip-count, --load-balancer-managed-outbound-ipv6-count to 0
Testing Guide
create a aks cluster and run following command
az aks update --load-balancer-outbound-ports 0History Notes
[AKS]
az aks update: Zero can be set to outbound-ports,outbound-ip-count in loadbalancer profile and outbound-ip-count in natgateway profile in aksThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.