[ACS] az aks update: Handle zero value for outbound_ports
#28265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
below command does not work as expected. $ az aks update -g rgname -n clustername --load-balancer-outbound-ports 0 --debug the reason is outbound_ports 0 is considered False. I added isinstance and none checking process.
jacobbaek
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @jacobbaek, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
jacobbaek
changed the title
followed the coding standard
jacobbaek
changed the title
az aks update: Handle outbound_ports 0
jacobbaek
changed the title
az aks update: Handle outbound_ports 0 az aks update: Handle zero value for outbound_ports
add a comment at the is_load_balancer_profile_provided.
jacobbaek
changed the title
az aks update: Handle zero value for outbound_ports az aks update: Handle zero value for outbound_ports
Delete a comment
|
There is another PR which is same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
below command does not work as expected.
the reason is outbound_ports 0 is considered False. I added isinstance and none checking process.
Related command
$ az aks update -g rgname -n clustername --load-balancer-outbound-ports 0 --debug
Description
If outbound_ports 0, it is considered False.
Even if outbound_ports is not None.
there need the checking logic for outbound_ports whether None or 0.
Given outbound_ports 0, the update process should work due to it is not None
Testing Guide
$ az aks update -g rgname -n clustername --load-balancer-outbound-ports 0 --debug
$ az aks show -g rgname -n clustername -o yaml | grep allocate
allocatedOutboundPorts: 0
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.