{AKS} Support reset default value for loadbalancer profile and natgateway profile #7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinForReal
requested review from
andyliuliming and
FumingZhang
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @MartinForReal, |
|
Hi @MartinForReal, |
|
AKS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
FumingZhang
reviewed
Jan 31, 2024
MartinForReal
force-pushed
the
shafan
branch
7 times, most recently
from
2f06694 to
f0d5411
Compare
FumingZhang
reviewed
Feb 1, 2024
Comment on lines
+2698
to
+2752
| if self.context.get_nat_gateway_managed_outbound_ip_count() is not None: | ||
| network_profile.nat_gateway_profile = create_nat_gateway_profile( | ||
| self.context.get_nat_gateway_managed_outbound_ip_count(), | ||
| self.context.get_nat_gateway_idle_timeout(), | ||
| models=self.models.nat_gateway_models, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Perhaps this part can be omitted as it's part of the create process, even if setting it to 0 is ignored, the default value will be backfilled to 0?
There was a problem hiding this comment.
The default value is 1
FumingZhang
reviewed
Mar 4, 2024
MartinForReal
force-pushed
the
shafan
branch
2 times, most recently
from
85aa474 to
99eae71
Compare
|
Requeued live test
|
The test passed. |
yanzhudd
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --load-balancer-outbound-ports 0General Guidelines
related: #27071
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.