Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BLKSEQ by default for Verilator #197

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Enable BLKSEQ by default for Verilator #197

merged 2 commits into from
Feb 15, 2024

Conversation

sgherbst
Copy link
Contributor

If this change breaks an existing test, the workaround is to set warnings=[] when instantiating SbDut. However, it is recommended to fix or explicitly disable lint for BLKSEQ warnings, because they can result in bugs that are hard to track down.

The code in this PR is set up to make it easy to add more non-default warnings in the future. I also needed to explicitly disable BLKSEQ in a few places in internal switchboard Verilog to resolve warnings that emerged.

@sgherbst sgherbst marked this pull request as ready for review February 15, 2024 22:03
@sgherbst sgherbst requested a review from volkamir February 15, 2024 22:14
Copy link

@volkamir volkamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@sgherbst sgherbst merged commit 53fe09f into main Feb 15, 2024
6 checks passed
@sgherbst sgherbst deleted the sgh/blkseq branch February 15, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants