zcash_client_backend: Make VKs optional for PCZT extraction #1729
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
commented
Mar 3, 2025
| &sapling::circuit::SpendVerifyingKey, | ||
| &sapling::circuit::OutputVerifyingKey, | ||
| )>, | ||
| #[cfg(feature = "orchard")] orchard_vk: Option<&orchard::circuit::VerifyingKey>, |
There was a problem hiding this comment.
Change not documented in changelog so that this PR doesn't conflict with #1673. This can happen in the release PR (or if the other PR merges before this one, after a rebase).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 54.15% 54.15% -0.01%
==========================================
Files 176 176
Lines 20475 20476 +1
==========================================
Hits 11088 11088
- Misses 9387 9388 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.