Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Make Sapling parameters optional for extract_and_store_transaction #1724

Closed
str4d opened this issue Mar 3, 2025 · 2 comments

Comments

@str4d
Copy link
Contributor

str4d commented Mar 3, 2025

We added the ability to check whether a PCZT contains a Sapling bundle, in order to determine whether Sapling parameters were necessary. But we forgot to make this part optional:

let transaction = TransactionExtractor::new(finalized)
.with_sapling(spend_vk, output_vk)
.with_orchard(orchard_vk)
.extract()?;

Alter this API to let the Sapling parameters be optional (and we may as well also make Orchard optional).

HonzaR added a commit to Electric-Coin-Company/zcash-android-wallet-sdk that referenced this issue Mar 3, 2025
That has been recently added, and that contains a bug; see zcash/librustzcash#1724
HonzaR added a commit to Electric-Coin-Company/zcash-android-wallet-sdk that referenced this issue Mar 3, 2025
* Changelog update

* Checkpoints update

* Update release date

* Remove check using pcztRequiresSaplingProofs

That has been recently added, and that contains a bug; see zcash/librustzcash#1724
@daira
Copy link
Contributor

daira commented Mar 3, 2025

Oops :-). Btw is that a 400-line function?

@str4d
Copy link
Contributor Author

str4d commented Mar 6, 2025

Closed by #1729.

@str4d str4d closed this as completed Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants