Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the invalid consensus branch id in the error message for read_v5_header_fragment #1716

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Show the invalid consensus branch id in the error message for read_v5_header_fragment #1716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion zcash_primitives/src/transaction/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,16 @@ impl Transaction {
fn read_v5_header_fragment<R: Read>(mut reader: R) -> io::Result<(BranchId, u32, BlockHeight)> {
let consensus_branch_id = reader.read_u32_le().and_then(|value| {
BranchId::try_from(value).map_err(|_e| {
io::Error::new(io::ErrorKind::InvalidInput, "invalid consensus branch id")
io::Error::new(
io::ErrorKind::InvalidInput,
#[cfg(not(feature = "std"))]
"invalid consensus branch id",
#[cfg(feature = "std")]
format!(
"invalid consensus branch id 0x{}",
hex::encode(value.to_be_bytes())
),
)
})
})?;
let lock_time = reader.read_u32_le()?;
Expand Down
Loading